[LOPS-2314] Adds retry option to Drush and WP-CLI commands #2588
+221
−28
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kporras07
reviewed
May 28, 2024
kporras07
reviewed
May 28, 2024
kporras07
reviewed
May 28, 2024
added 2 commits
May 28, 2024 14:14
src/Commands/Remote/WPCommand.php
Outdated
| { | ||
| $this->prepareEnvironment($site_env); | ||
| $this->setProgressAllowed($options['progress']); | ||
| return $this->executeCommand($wp_command); | ||
| $retries = isset($options['retry']) ? (int)$options['retry'] : 0; |
There was a problem hiding this comment.
I think that ?: is available in php 7.4. If so, this could just be (int)$options['retry'] ?: 0;
There was a problem hiding this comment.
Terminus uses this operator elsewhere.
There was a problem hiding this comment.
Do we want (int)$options['retry'] ?: 0; or (int)($options['retry'] ?? 0);?
There was a problem hiding this comment.
The first looks clearer to me, but both should behave the same. You may use the later if you prefer it.
namespacebrian
approved these changes
May 30, 2024
greg-1-anderson
approved these changes
May 31, 2024
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
Screen.Recording.2024-05-29.at.10.58.38.AM.mov
CCB Ticket