[SITE-3292] add @maybe-add-symlinks to post-update-cmd #175
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
add the symlinks if they don't already exist
pwtyler
approved these changes
Feb 10, 2025
This update applies the same check to create symlinks to files in the `web/` directory that is run on `composer install` commands to `composer update` as well. This ensures that symlinks are created with upstream updates are applied (`composer update`) as well as when new commits to a site repository are pushed (`composer install`). For more information, see https://docs.pantheon.io/release-notes/2025/02/wordpress-composer-managed-1-32-5
jazzsequence
force-pushed
the
site-3578-post-update-cmd
branch
from
e84ffff to
6a719df
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add the symlinks if they don't already exist.
When applying the upstream updates from 1.32.4, it was discovered that the symlinks to
wp-*files (and theindex.phpfile creation) is not run leaving the site in an empty state. When cache expires, the site will be broken with the files missing. (Perhaps this was the issue all along?)This uses the existing
ComposerScriptsclass andpreUpdatehook (hooked to the composerpre-update-cmd) to update thecomposer.jsonto add@maybe-install-symlinksif that's not already part of thepost-update-cmd. Thepost-update-cmdis also created by this script (if it did not exist already), so this change checks for the existance of the script we're adding and adds it if it's not there, which is then run after thecomposer updateis executed.