Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix method declaration for methods used statically #176

Merged
merged 2 commits into from
Jan 22, 2020
Merged

Fix method declaration for methods used statically #176

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
c165a54
Fix method declaration for methods used statically
danielbachhuber Jan 22, 2020
6611732
Update README for v0.8.2
danielbachhuber Jan 22, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@
**Tags:** authentication, SAML
**Requires at least:** 4.4
**Tested up to:** 5.3
**Stable tag:** 0.8.1
**Stable tag:** 0.8.2
**License:** GPLv2 or later
**License URI:** http://www.gnu.org/licenses/gpl-2.0.html

Expand Down Expand Up @@ -277,6 +277,9 @@ There is no third step. Because SimpleSAMLphp loads WordPress, which has WP Nati

## Changelog ##

### 0.8.2 (January 22, 2020) ###
* Fixes method declaration for methods used statically [[#176](https://github.com/pantheon-systems/wp-saml-auth/pull/176)].

### 0.8.1 (November 25, 2019) ###
* Updates `onelogin/php-saml` to `v3.4.1` [[#174](https://github.com/pantheon-systems/wp-saml-auth/pull/174)].

Expand Down
4 changes: 2 additions & 2 deletions inc/class-wp-saml-auth-options.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -61,7 +61,7 @@ public static function get_option_name() {
*
* @return boolean
*/
public function has_settings_filter() {
public static function has_settings_filter() {
$filter1 = remove_filter( 'wp_saml_auth_option', 'wpsa_filter_option', 0 );
$filter2 = remove_filter( 'wp_saml_auth_option', array( self::$instance, 'filter_option' ), 9 );
$has_filter = has_filter( 'wp_saml_auth_option' );
Expand All @@ -84,7 +84,7 @@ public function has_settings_filter() {
*
* @return boolean
*/
public function do_required_settings_have_values() {
public static function do_required_settings_have_values() {
$options = get_option( self::get_option_name() );
$retval = null;
foreach ( WP_SAML_Auth_Settings::get_fields() as $field ) {
Expand Down
5 changes: 4 additions & 1 deletion readme.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@ Contributors: getpantheon, danielbachhuber, Outlandish Josh
Tags: authentication, SAML
Requires at least: 4.4
Tested up to: 5.3
Stable tag: 0.8.1
Stable tag: 0.8.2
License: GPLv2 or later
License URI: http://www.gnu.org/licenses/gpl-2.0.html

Expand Down Expand Up @@ -277,6 +277,9 @@ There is no third step. Because SimpleSAMLphp loads WordPress, which has WP Nati

== Changelog ==

= 0.8.2 (January 22, 2020) =
* Fixes method declaration for methods used statically [[#176](https://github.com/pantheon-systems/wp-saml-auth/pull/176)].

= 0.8.1 (November 25, 2019) =
* Updates `onelogin/php-saml` to `v3.4.1` [[#174](https://github.com/pantheon-systems/wp-saml-auth/pull/174)].

Expand Down