Skip to content

Commit

Permalink
Hotfix for #6981 breaking release.sh (#7091)
Browse files Browse the repository at this point in the history
## Problem
#6981 led to the `Deploy unstable multiplatform pants.pex` shard failing consistently. The error can be reproduced locally via `./build-support/bin/release.sh -p`. The error message, however, is not very descriptive, even with `set -x` and `PANTS_VERBOSE=9`.

## Solution
The likely culprit is removing `osx_image: xcode8` from the `OSX build wheels` shard. We had this hardcoded before #7091 for a reason, and removing it is probably what messed things up. The removal was not intentional, merely an oversight.

Also, this changes the wheel shards to not have py2 vs py3 setups, as they don't use a PEX so the distinction is not meaningful at the moment.

## Result
The result *cannot* be verified until being merged into master. This is because Travis never allows the `deploy` stage to happen from pull requests, as it's a security concern.
  • Loading branch information
Eric-Arellano authored Jan 17, 2019
1 parent f7d9d5d commit 1d5a2f4
Show file tree
Hide file tree
Showing 2 changed files with 20 additions and 68 deletions.
44 changes: 10 additions & 34 deletions .travis.yml
Original file line number Diff line number Diff line change
Expand Up @@ -321,46 +321,30 @@ py3_osx_build_engine: &py3_osx_build_engine
# -------------------------------------------------------------------------

base_build_wheels: &base_build_wheels
stage: *test
env:
- &base_build_wheels_env RUN_PANTS_FROM_PEX=1 PREPARE_DEPLOY=1
script:
- ./build-support/bin/release.sh -n

py2_linux_build_wheels: &py2_linux_build_wheels
linux_build_wheels: &linux_build_wheels
<<: *py2_linux_test_config
<<: *base_build_wheels
name: "Build Linux wheels (Py2 PEX)"
name: "Build Linux wheels (No PEX)"
env:
- *py2_linux_test_config_env
- *base_build_wheels_env
- CACHE_NAME=linuxwheelsbuild.py2
- CACHE_NAME=linuxwheelsbuild

py3_linux_build_wheels: &py3_linux_build_wheels
<<: *py3_linux_test_config
<<: *base_build_wheels
name: "Build Linux wheels (Py3 PEX)"
env:
- *py3_linux_test_config_env
- *base_build_wheels_env
- CACHE_NAME=linuxwheelsbuild.py3

py2_osx_build_wheels: &py2_osx_build_wheels
osx_build_wheels: &osx_build_wheels
<<: *py2_osx_test_config
<<: *base_build_wheels
name: "Build OSX wheels (Py2 PEX)"
name: "Build OSX wheels (No PEX)"
osx_image: xcode8
env:
- *py2_osx_test_config_env
- *base_build_wheels_env
- CACHE_NAME=osxwheelsbuild.py2

py3_osx_build_wheels: &py3_osx_build_wheels
<<: *py3_osx_test_config
<<: *base_build_wheels
name: "Build OSX wheels (Py3 PEX)"
env:
- *py3_osx_test_config_env
- *base_build_wheels_env
- CACHE_NAME=osxwheelsbuild.py3
- CACHE_NAME=osxwheelsbuild

# -------------------------------------------------------------------------
# OSX sanity checks
Expand Down Expand Up @@ -577,16 +561,8 @@ matrix:
- <<: *py2_osx_build_engine
- <<: *py3_osx_build_engine

# TODO(6450): add support for Py3 in the release script. This can't be done until
# Pants is ready to be built and released as a Py3 wheel.
- <<: *py2_linux_build_wheels
stage: *test
# - <<: *py3_linux_build_wheels

# TODO(6450): see above about adding support for Py3 in release script.
- <<: *py2_osx_build_wheels
stage: *test
# - <<: *py3_osx_build_wheels
- <<: *linux_build_wheels
- <<: *osx_build_wheels

- <<: *py2_osx_10_12_sanity_check
- <<: *py3_osx_10_12_sanity_check
Expand Down
44 changes: 10 additions & 34 deletions build-support/travis/travis.yml.mustache
Original file line number Diff line number Diff line change
Expand Up @@ -300,46 +300,30 @@ py3_osx_build_engine: &py3_osx_build_engine
# -------------------------------------------------------------------------
base_build_wheels: &base_build_wheels
stage: *test
env:
- &base_build_wheels_env RUN_PANTS_FROM_PEX=1 PREPARE_DEPLOY=1
script:
- ./build-support/bin/release.sh -n
py2_linux_build_wheels: &py2_linux_build_wheels
linux_build_wheels: &linux_build_wheels
<<: *py2_linux_test_config
<<: *base_build_wheels
name: "Build Linux wheels (Py2 PEX)"
name: "Build Linux wheels (No PEX)"
env:
- *py2_linux_test_config_env
- *base_build_wheels_env
- CACHE_NAME=linuxwheelsbuild.py2
- CACHE_NAME=linuxwheelsbuild
py3_linux_build_wheels: &py3_linux_build_wheels
<<: *py3_linux_test_config
<<: *base_build_wheels
name: "Build Linux wheels (Py3 PEX)"
env:
- *py3_linux_test_config_env
- *base_build_wheels_env
- CACHE_NAME=linuxwheelsbuild.py3
py2_osx_build_wheels: &py2_osx_build_wheels
osx_build_wheels: &osx_build_wheels
<<: *py2_osx_test_config
<<: *base_build_wheels
name: "Build OSX wheels (Py2 PEX)"
name: "Build OSX wheels (No PEX)"
osx_image: xcode8
env:
- *py2_osx_test_config_env
- *base_build_wheels_env
- CACHE_NAME=osxwheelsbuild.py2
py3_osx_build_wheels: &py3_osx_build_wheels
<<: *py3_osx_test_config
<<: *base_build_wheels
name: "Build OSX wheels (Py3 PEX)"
env:
- *py3_osx_test_config_env
- *base_build_wheels_env
- CACHE_NAME=osxwheelsbuild.py3
- CACHE_NAME=osxwheelsbuild
# -------------------------------------------------------------------------
# OSX sanity checks
Expand Down Expand Up @@ -556,16 +540,8 @@ matrix:
- <<: *py2_osx_build_engine
- <<: *py3_osx_build_engine
# TODO(6450): add support for Py3 in the release script. This can't be done until
# Pants is ready to be built and released as a Py3 wheel.
- <<: *py2_linux_build_wheels
stage: *test
# - <<: *py3_linux_build_wheels

# TODO(6450): see above about adding support for Py3 in release script.
- <<: *py2_osx_build_wheels
stage: *test
# - <<: *py3_osx_build_wheels
- <<: *linux_build_wheels
- <<: *osx_build_wheels
- <<: *py2_osx_10_12_sanity_check
- <<: *py3_osx_10_12_sanity_check
Expand Down

0 comments on commit 1d5a2f4

Please sign in to comment.