Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Remove redundant names and logging. (#9921)
### Problem Post #9894, it's clear that many named rules are redundant, because the processes that run below them have better descriptions (relates to #7907, although it's possible that we'd like to drive the names of a workunit in some other way). Example for a `--no-process-execution-use-local-cache` run: ``` 18:00:22:852 [INFO] Starting tests: tests/python/pants_test/util:strutil 18:00:22:870 [INFO] Completed: Create a PEX from targets 18:00:24:029 [INFO] Completed: Building test_runner.pex 18:00:24:030 [INFO] Completed: Building requirements.pex 18:00:24:031 [INFO] Completed: Create PEX 18:00:24:031 [INFO] Completed: Create PEX 18:00:32:638 [INFO] Completed: Building pytest.pex with 8 requirements: ipdb, pygments, <snip> 18:00:32:639 [INFO] Completed: Create PEX 18:00:34:480 [INFO] Completed: Run Pytest for tests/python/pants_test/util:strutil 18:00:34:480 [INFO] Completed: Run pytest 18:00:34:481 [INFO] Tests succeeded: tests/python/pants_test/util:strutil ✓ tests/python/pants_test/util:strutil ============================= test session starts ============================== <snip> ============================== 6 passed in 0.03s =============================== 18:00:34:481 [INFO] Completed: `test` goal ``` Likewise, when the process cache is hit on a run without `pantsd`, the `@rules` will run ("Create PEX" etc) but the processes won't because they'll have been persistently cached... which makes the output even less useful. ### Solution While we should pursue #7907, and likely also allow `@rule`s to explicitly declare their level, some rule names just won't be useful when compared to the process names we've generated. Prune a few. ### Result Output for the same uncached command is: ``` 00:35:51:820 [INFO] Completed: Building requirements.pex 00:35:51:821 [INFO] Completed: Building test_runner.pex 00:36:02:208 [INFO] Completed: Building pytest.pex with 8 requirements: ipdb, pygments, <snip> 00:36:04:487 [INFO] Completed: Run Pytest for tests/python/pants_test/util:strutil 00:36:04:488 [INFO] Tests succeeded: tests/python/pants_test/util:strutil ✓ tests/python/pants_test/util:strutil ============================= test session starts ============================== <snip> ============================== 6 passed in 0.03s =============================== 18:05:23:318 [INFO] Completed: `test` goal ``` See also: the travis output for this run. [ci skip-jvm-tests] [ci skip-rust-tests]
- Loading branch information