empty strings are falsey in python!

pantsbuild · Jan 22, 2019 · b26ab52 · b26ab52
1 parent 95374d0
commit b26ab52
Showing 1 changed file with 3 additions and 1 deletion.
diff --git a/src/python/pants/util/dirutil.py b/src/python/pants/util/dirutil.py
@@ -143,8 +143,10 @@ def safe_file_write(filename, payload=None, mode=None):
   :param string payload: The string to write to the file. Defaults to the empty string.
   :param string mode: A mode argument for the python `open` builtin. Defaults to 'w' (text).
   """
+  if payload is None:
+    payload = ''
   with safe_open(filename, mode=mode or 'w') as f:
-    f.write(payload or '')
+    f.write(payload)
 
 
 def maybe_read_file(filename, binary_mode=None):