Nested package statements not inferred for Scala

[stuhood]

package akka.shapeless
package ops

...results in symbols in both packages being available as unqualified within the file.

This is likely because we don't attempt to resolve against all of the nested scopes for a symbol here:

pants/src/python/pants/backend/scala/dependency_inference/scala_parser.py

Lines 132 to 140 in c7cd090

	# TODO: We compute "the package" as the "shortest scope in the file" to handle the most
	# common case of consuming a type from within your package. But this doesn't account
	# for the fact that any of the intermediate scopes might be relevant as well. Solving that
	# would require resolving the type recursively upward.
	package = min(
	(*self.imports_by_scope.keys(), *self.consumed_symbols_by_scope.keys()),
	key=len,
	default="",
	)

[tdyas]

@stuhood: Is there a particular example of this? I'm not sure what is meant by "results in symbols in both packages being available". The provided symbols calculated for a file should all be attributed to akka.shapeless.ops, correct?

[stuhood]

Sorry, clarified the description to indicate that this is about which symbols are available as unqualified within the file, rather than which package declared symbols live in.

[tdyas]

Example of how it should work:

Foo.scala:

package foo

object Foo {
  def grok(): Unit = {
    println("Foo.grok")
  }
}

Main.scala:

package foo
package bar

object Main {
  def main(args: Array[String]): Unit = {
    Foo.grok()
  }
}

foo.bar.Main can refer to foo.Foo since it has a package foo directive.

Okay first step will be a PR to analyze the actual package statements.

[tdyas]

#13738 parses out the package scopes.

[stuhood]

This represented roughly 10% of the issues in akka-http.