Some Resources in maven layout get the wrong source root, should be picking up 'src/test/resources' and 'src/main/resources' over 'src'

[ericzundel]

I have some tests that have some '.java' files on the resource path. This is not so strange as it sounds - they are used to test an annotation processor.

e.g.

foo/src/main/resources/com/example/Metrics.java

foo/src/main/resources/BUILD included them in a resources() target and a test target had a dependency on them.

In 0.0.53, these resources were visible, but as of 0.0.57 they are not. I suspect something is filtering them out of the classpath, thinking they are generated sources from an annotation processor, but for these resources that is not the case.

Still investigating this, that might not be the issue...

[ericzundel]

I think this is a source roots problem:

One of our files is written to:

.pants.d/resources/prepare/common-annotation-processors.tests.src.test.resources.resources/bc8572527ebf/test/resources/aop/BadVisibility.java

The file is in common-annotation-processors/tests/src/test/resources . Look at the path written to the build cache. There is a directory test/resources after the sha in the path that I didn't expect to be there.

Before this change, the file was written to:

.pants.d/resources/prepare/fd25894586b06db15abfc6266ece1d0bfbcd21e4-TaskIdentityFingerprintStrategy_25888fb3bc8e/aop/BadVisibility.java

[ericzundel]

I think I see what might be the problem. This source code is under

common-annotation-procesors/tests/src/test/resources

I think maybe the 'tests' or 'tests/src' in the path preceding may be fooling the source root code. We have several projects like this and now I see that others are also failing in the upgrade, (I was just focused in on this one because we just recently got it to work.)

This works around the problem:

[source]
source_roots: {
    "common-annotation-processors/tests/src/main/resources": ["java"]
  }

FYI @benjyw do you think there is a better solution to this?

[stuhood]

You could remove the 'tests/*' source root pattern, or rename those
directories to not match that pattern.
On Nov 11, 2015 5:56 AM, "Eric Ayers" [email protected] wrote:

I think I see what might be the problem. This source code is under

common-annotation-procesors/tests/src/test/resources

I think maybe the 'tests' or 'tests/src' in the path preceding may be
fooling the source root code. We have several projects like this and now I
see that others are also failing in the upgrade, (I was just focused in on
this one because we just recently got it to work.)

This works around the problem:

[source]
source_roots: {
"common-annotation-processors/tests/src/main/resources": ["java"]
}

FYI @benjyw https://github.com/benjyw do you think there is a better
solution to this?

—
Reply to this email directly or view it on GitHub
#2536 (comment).

[ericzundel]

Thanks @stuhood. This is better:

[source]
test_root_patterns: [
    "test/*",
    "src/test/*"
  ]

[benjyw]

That seems like the right solution to me. The source root code was working as advertised, with the defaults it was given.

[ericzundel]

Well, the odd part about this is that common-annotation-processors/tests/src/main/java and common-annotation-processors/tests/src/main/proto seem to work the way I want it to so the break is hard to pin back to source roots.

[benjyw]

My guess is that java "worked" because you didn't need correct source roots for them (because you weren't bundling that code).

[stuhood]

@ericzundel : Sounds like this was Not A Bug?