-
-
Notifications
You must be signed in to change notification settings - Fork 652
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[rsc-compile] break out java metacping into a separate job #6754
Comments
Thank you @baroquebobcat... will tackle this this/next week. |
stuhood
pushed a commit
that referenced
this issue
Jan 2, 2019
…n graph node. (#6940) ### Problem As described in #6754: Currently java targets are metacp'd as part of building each scala target. It would be better to metacp them once per java target. ### Solution Rename `work_for_vts_rsc_jar_library` to `work_for_vts_metacp`, and reuse it for metacp'ing java libraries after compilation. ### Result Fixes #6754.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Currently java targets are metacp'd as part of building each scala target. It would be better to metacp them once per java target.
There's a couple approaches here
Job
thatThis is very similar to 2be0b1d#diff-074dd871ff62c835ab90d4a0a1264a63
work_for_vts_rsc
https://github.com/pantsbuild/pants/blob/master/src/python/pants/backend/jvm/tasks/jvm_compile/rsc/rsc_compile.py#L435I haven't spent much time refactoring this, so there is a lot of duplication.
The text was updated successfully, but these errors were encountered: