Upgrade to Pex 2.1.50 and leverage packed layout. (Cherry picks of 433a4dd 0d36002 7ba06a5) #13078
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pex 2.1.48 brings `--layout {packed,loose}` alternate layouts for PEXes.
These are both more friendly to remote caching, leading to smaller
artifacts to cache and greater cache hit ratios in the face of
requirement changes. Since the loose layout still does not perform well
with the local CAS scheme, we use packed for now.
Fixes pantsbuild#12548
Fixes pantsbuild#12688
Fixes pantsbuild#12803
(cherry picked from commit 433a4dd)
# Rust tests and lints will be skipped. Delete if not intended.
[ci skip-rust]
# Building wheels and fs_util will be skipped. Delete if not intended.
[ci skip-build-wheels]
This fixes a bug activating previously `--not-zip-safe` dependency-only PEXes, which Pants used extensively before the Pex 2.1.48 upgrade. (cherry picked from commit 0d36002) # Rust tests and lints will be skipped. Delete if not intended. [ci skip-rust] # Building wheels and fs_util will be skipped. Delete if not intended. [ci skip-build-wheels]
This fixes a bug executing PEX zipapps that do not have the execute bit set, which is the case for the Pex PEX we download and run in the release script. (cherry picked from commit 7ba06a5) # Rust tests and lints will be skipped. Delete if not intended. [ci skip-rust] # Building wheels and fs_util will be skipped. Delete if not intended. [ci skip-build-wheels]
# Building wheels and fs_util will be skipped. Delete if not intended. [ci skip-build-wheels] # Rust tests and lints will be skipped. Delete if not intended. [ci skip-rust]
|
I'm open to how to structure this. The additional cherry-picks are needed to avoid issues with the PEX_ROOT from old Pex versions and to ensure the release script works. |
stuhood
approved these changes
Oct 1, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a three-part-cherry-pick:
Pex 2.1.48 brings
--layout {packed,loose}alternate layouts for PEXes.These are both more friendly to remote caching, leading to smaller
artifacts to cache and greater cache hit ratios in the face of
requirement changes. Since the loose layout still does not perform well
with the local CAS scheme, we use packed for now.
Fixes #12548
Fixes #12688
Fixes #12803
(cherry picked from commit 433a4dd)
This fixes a bug activating previously
--not-zip-safedependency-onlyPEXes, which Pants used extensively before the Pex 2.1.48 upgrade.
(cherry picked from commit 0d36002)
This fixes a bug executing PEX zipapps that do not have the execute bit
set, which is the case for the Pex PEX we download and run in the
release script.
(cherry picked from commit 7ba06a5)
With a fourth commit that applies
./build-support/bin/generate_all_lockfiles.sh.Fixes #13075