Ensure PATH to shims are absolute for the protobuf buf linter. #17367
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stuhood
approved these changes
Oct 27, 2022
jyggen
approved these changes
Oct 27, 2022
tdyas
reviewed
Oct 27, 2022
| @@ -98,7 +99,7 @@ async def run_buf_format( | |||
| output_files=request.files, | |||
| description=f"Run buf format on {pluralize(len(request.files), 'file')}.", | |||
| level=LogLevel.DEBUG, | |||
| env={"PATH": binary_shims.bin_directory}, | |||
| env={"PATH": os.path.join("{chroot}", binary_shims.bin_directory)}, | |||
There was a problem hiding this comment.
This won't work with remote execution without a wrapper script. (This is a general problem of {chroot} not specific to buf.)
There was a problem hiding this comment.
Coincidentally, this should be solvable in remote execution once #17290 lands because that adds a wrapper script for remote execution to support append-only caches in the remote environment. Then solving the PATH issue is just a matter of adding the additional shell code to substitute in the remote executor's input root path.
There was a problem hiding this comment.
PATH=${PATH//\{chroot\}/$(pwd)}
tdyas
pushed a commit
that referenced
this pull request
Oct 27, 2022
… `DirectoryDigest` (#17370) Modify `make_execute_request` to be async, take a `Store` as a parameter, and to return the input root to use. This is prework for #17290 which needs the ability to make a new input root digest if a wrapper script needs to be added to the input root. (It will also be useful for other wrapper script applications, such as to solve the issue at #17367 (comment) for remote execution.)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #17363