Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add lint backend to run semgrep #18593
Add lint backend to run semgrep #18593
Changes from 1 commit
c041769
f4bde7f
8955c50
a2fa07b
56dccf9
955538e
68fc026
8be9b21
594d1ea
790fe51
4f33a5d
89c5b4d
25733f3
2bb0672
323f693
d08611f
798ad6c
a381711
987b484
613fc83
d0f5d4e
b86ba09
3efeac6
a405f7b
1fad45e
f71db25
42f9683
ec9c1fd
ec79db0
d7ff26e
b390be2
00d4a97
a208b90
e2ca370
a198538
af1101f
71091e6
e2902ac
cee2487
05c49c4
a3c7e07
5f7fdaa
195d090
9c68431
ace84a6
409e73c
25c4f48
385666a
5db7e97
16f22c4
ed0687a
4593fb2
db6bc2e
7e7135f
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Side observation (not suggesting actionable in this PR):
I think it is unfortunate to depend on the entire
GlobalOptions
when it is only a singlebool
value you care about.I see this is the case in quite a few other places as well, which makes me think we might want to consider having a generic
IsColorEnabled
API type along with a rule that extracts theGlobalOptions.color
value.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've been meaning to generate a rule per option from subsystems...
Let me file a ticket...
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oh this is interesting. I have long standing thoughts on how a hybrid plugin would work with targets.
Anything with a source seems like a good way of doing that
🙌
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Cool 👍
(Coincidentally, your comment makes me realise that the
Dependencies
field isn't used any more, so I should get rid of it. Note to self.)There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hmm I feel like there's an example of targets that operate on a level that isn't single-file. Maybe this should be any source field?
You can still run it on individual files, but you'll match more targets.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
were you still getting rid of the dependencies field?