Extend deprecation period for python_awslambda alias
#20101
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
huonw
added
needs-cherrypick
category:internal
benjyw
approved these changes
Oct 27, 2023
|
I tried to automatically cherry-pick this change back to each relevant milestone, so that it is available in those older releases of Pants. ❌ 2.18.xI was unable to cherry-pick this PR to 2.18.x, likely due to merge-conflicts. Steps to Cherry-Pick locallyTo resolve:
Please note that I cannot re-run CI if a job fails. Please work with your PR approver(s) to re-run CI if necessary. When you're done manually cherry-picking, please remove the Thanks again for your contributions! |
huonw
added a commit
that referenced
this pull request
Oct 31, 2023
This PR extends the deprecation of the old `python_awslambda` alias for the `python_aws_lambda_function` target, to make it easier/smoother for people to upgrade to 2.18 and particularly 2.19. We renamed the `python_awslambda` target to `python_aws_lambda_function` in #19216 (in 2.18), and deprecated the old name. This was originally scheduled to be removed in 2.19, and happened in #19759, but I've reconsidered that slightly: 2.17 - 2.19 is a time of much upheaval for Pants' FaaS support, so it seems sensible to try to smooth that over if we can, especially for something like this, that's just two lines of configuration (not even "real" code).
huonw
added a commit
that referenced
this pull request
Oct 31, 2023
…#20101) (#20125) This PR extends the deprecation of the old `python_awslambda` alias for the `python_aws_lambda_function` target, to make it easier/smoother for people to upgrade to 2.18 and particularly 2.19. We renamed the `python_awslambda` target to `python_aws_lambda_function` in #19216 (in 2.18), and deprecated the old name. This was originally scheduled to be removed in 2.19, and happened in #19759, but I've reconsidered that slightly: 2.17 - 2.19 is a time of much upheaval for Pants' FaaS support, so it seems sensible to try to smooth that over if we can, especially for something like this, that's just two lines of configuration (not even "real" code).
This was referenced Feb 26, 2024
huonw
added a commit
that referenced
this pull request
Feb 27, 2024
The `python_awslambda` target was replaced by `python_aws_lambda_function` in #19216, first released in 2.18.0.dev1 (the deprecation was extended in #20101). We're now up to 2.21 (#20609), and thus the deprecation has expired and this can be removed. This has been deprecated for 3 versions, and is easy for users to adapt to, so doesn't seem worth extending.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR extends the deprecation of the old
python_awslambdaalias for thepython_aws_lambda_functiontarget, to make it easier/smoother for people to upgrade to 2.18 and particularly 2.19.We renamed the
python_awslambdatarget topython_aws_lambda_functionin #19216 (in 2.18), and deprecated the old name. This was originally scheduled to be removed in 2.19, and happened in #19759, but I've reconsidered that slightly: 2.17 - 2.19 is a time of much upheaval for Pants' FaaS support, so it seems sensible to try to smooth that over if we can, especially for something like this, that's just two lines of configuration (not even "real" code).