Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

WIP: SnapshotBackedEagerFilesetWithSpec #5856

Closed
wants to merge 4 commits into from
Closed

WIP: SnapshotBackedEagerFilesetWithSpec #5856

wants to merge 4 commits into from

Conversation

illicitonion
Copy link
Contributor

No description provided.

@stuhood
Copy link
Member

stuhood commented May 22, 2018

Thanks for diving in to this.

I think that post #5611 I should probably start on a followup that adapts BaseTest/TestBase.make_target to use a unified construction pipeline with BUILD file parsing... currently it calls the Target constructor directly, which does not allow for intercepting the arguments and pre-processing them (as in field hydration).

This is related to #4535, which is still a little bit up in the air.

@illicitonion illicitonion mentioned this pull request May 23, 2018
Closed
@illicitonion illicitonion deleted the dwagnerhall/cloc/sourcesnapshots branch August 15, 2018 03:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@illicitonion @stuhood