[WIP, pending performance investigations] remote hermetic experiments revisited #7231
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cosmicexplorer
changed the title
cosmicexplorer
force-pushed
the
remoting-FINAL
branch
4 times, most recently
from
dc52e7f to
4c0b5b3
Compare
…exceptions - this also requires none_is_default=True to be set in .create() calls to coerce None
…gration.py (this makes addressing pantsbuild#6866 later a little easier)
…exceptions - this also requires none_is_default=True to be set in .create() calls to coerce None
add experimental hermetic-with-nailgun jvm execution strategy upstream all the jvm task changes make rsc jobs populate the runtime_classpath for subsequent zinc jobs! mixed mode compilation 100% works mjar -> jar start outling compiling java with rsc revert hermetic with nailgun changes [BROKEN] revert enum changes and process stringification Revert "add experimental hermetic-with-nailgun jvm execution strategy" This reverts commit 6fd30defa11622ac13b92768eabe15d1b94df556. extraneous edits to support the new enum fix lint
…exceptions - this also requires none_is_default=True to be set in .create() calls to coerce None
cosmicexplorer
force-pushed
the
remoting-FINAL
branch
from
3599354 to
010c498
Compare
|
Closed for now, the commits should be easily cherry-pickable. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is based off of #7227: see https://github.com/cosmicexplorer/pants/compare/cosmicexplorer:mixed-rsc-zinc-compiles...cosmicexplorer:remoting-FINAL?expand=1. The previous commits will be removed when that PR is merged.
The scala edits in this commit should be unchanged from twitter@3e798c1.
Problem
One interesting possibility for distributed rsc compilation is to have individual remote execution workers maintain a nailgun instance which individual process executions connect to. This removes JVM startup time and allows the JIT to warm up (vaguely). This is pretty difficult to set up (as described below) but if the relative performance is convincing, may deserve more investigation.
(explain the context of the problem and why you're making this change. include
references to all relevant github issues.)
Solution
hermetic-with-nailgunexecution strategy to connect to a remote execution server which is running its own nailgun server in the background../pants binary src/scala/org/pantsbuild/zinc/compiler:rsc-and-zincon its classpath.NAILGUN_PORTin its execution sandbox -- this is difficult to set up and likely insecure, along with other concerns I am less familiar with.Please look at the
--ng-client-input-digestand--ng-client-input-digest-lengthoption descriptions to understand the requirements for thengcommand-line client used to perform this connection: https://github.com/cosmicexplorer/pants/blob/a33b43dc15898a71c7f8e8f41478da5564a0fbc2/src/python/pants/backend/jvm/tasks/jvm_compile/zinc/zinc_compile.py#L178-L188(describe the modifications you've made.)
Result
(describe how your changes affect the end-user behavior of the system. this section is
optional, and should generally be summarized in the title of the pull request.)