Fix dependency cycle between backend/native/subsystems
and backend/python/subsystems
#7793
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
backend/python/subsystems/python_native_code.py
was depending onpants.backend.native.subsystems
, but not declaring the dependency in itsBUILD
file.The naive solution of adding the proper depedency to its
BUILD
results in a dependency cycle, asbackend/native/subsystems/conan.py
already depends depending onpants.backend.python.subsystems.python_tool_base
.So,
./pants test tests/python/pants_test/backend/python/tasks:pytest_run
would fail when ran directly, but pass in CI because all of the targets would get the sources combined.When changing to using the V2 test runner, we no longer allow this sort of leaky dependency usage—every dependency must be properly declared in the appropriate
BUILD
file. So,./pants test tests/python/pants_test/backend/python/tasks:pytest_run
started failing in #7724.Solution
Move
conan.py
into a new subdirectorybackend/native/subsystems/packaging
, as suggested by @cosmicexplorer.