-
-
Notifications
You must be signed in to change notification settings - Fork 652
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Avoid redundant work while hackily_snapshot()ing. #7829
Avoid redundant work while hackily_snapshot()ing. #7829
Conversation
3f23f64
to
bef33a3
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not super familiar with threading
but this seems ideal! I would love to add a test which exercises the possibility of a multithreaded download (what this PR fixes), especially since that test would seem to still work upon conversion to v2 -- is there an easy way to do that by just kicking off two threads downloading a tool at once? If a test for that isn't easy or is likely to be flaky then I would love a TODO about that at least so we clearly know what things aren't being tested yet.
Restarted a failing contrib shard! |
That would end up being a test of the rust |
### Problem In runs with high degrees of concurrency, we end up seeing many simultaneous instances of tools being fetched and snapshotted. ### Solution Enforce a single fetch+snapshot attempt per tool. As mentioned in the comment, this is a temporary solution until #7790 migrates this into the engine itself.
### Problem In runs with high degrees of concurrency, we end up seeing many simultaneous instances of tools being fetched and snapshotted. ### Solution Enforce a single fetch+snapshot attempt per tool. As mentioned in the comment, this is a temporary solution until #7790 migrates this into the engine itself.
Problem
In runs with high degrees of concurrency, we end up seeing many simultaneous instances of tools being fetched and snapshotted.
Solution
Enforce a single fetch+snapshot attempt per tool. As mentioned in the comment, this is a temporary solution until #7790 migrates this into the engine itself.