avoid digesting the rsc classpath on each iteration #7837
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stuhood
approved these changes
Jun 3, 2019
| PathGlobs(tuple(cp_rel)), | ||
| text_type(get_buildroot())) | ||
| cp_snapshot, = self.context._scheduler.capture_snapshots((cp_globs,)) | ||
| # TODO: A Snapshot can have `.files` and `.dirs` in arbitrary order, which doesn't allow |
There was a problem hiding this comment.
The files and dirs in a Snapshot are sorted post #7241.
| # using a `Digest`ed classpath requires separately passing along the original (relativized) | ||
| # classpath paths. Individual `ClasspathEntry`s can be created, but those only allow a single | ||
| # path per digest, which isn't possible when digesting multiple paths at once, as we do here. | ||
| return (cp_rel, cp_snapshot) |
There was a problem hiding this comment.
Consider using a ClasspathEntry for this?
|
I picked this up and finished it off in another PR :) Thanks for starting it off! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
We currently convert the rsc tool's classpath into
PathGlobsAndRootand callself.context._scheduler.capture_snapshots()on every single rsc invocation (unless--rsc-native-imageis provided). We don't need to digest these files every time -- they should remain the same across all invocations.Solution
self._rsc_classpath_snapshotto avoid snapshotting the rsc classpath more than once.Result
There may be a slight performance boost to the rsc compile task.