Remove tests from V2 unit test blacklist that were already passing #8060
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Eric-Arellano
commented
Jul 17, 2019
Eric-Arellano
changed the title
Eric-Arellano
force-pushed
the
v2-blacklist
branch
from
f03ffb6 to
e92c438
Compare
blorente
approved these changes
Jul 17, 2019
stuhood
approved these changes
Jul 17, 2019
stuhood
pushed a commit
that referenced
this pull request
Jul 24, 2019
### Problem While #7696 added support for source roots, its implementation of stripping the actual prefix from the file broke use of resources, specifically when referring to their path in source code, e.g. calling `open('tests/python/pants_test/backend/jvm/tasks/ivy_utils.py')`. This is because we physically stripped the name, so the hardcoded file path would need to be updated to `'pants_test/backend/jvm/tasks/ivy_utils.py'`. Per #8060 (comment), this is not acceptable because it changes a public API. We must have a way to relativize Python files so that their import statements work, but to also keep the full path. ### Solution By populating the `PYTHONPATH` env var for the Pex that runs Pytest with the unique source root paths, Python absolute imports work without actually having to strip any prefix. This appears similar to what [Pycharm and IntelliJ do](https://stackoverflow.com/questions/21199382/why-does-pycharm-always-add-contents-root-to-my-pythonpath-and-what-pythonpat). #### Alternative attempted: use `PEX`'s `--source-directory` PEX is able to understand source roots via its `--source-directory` and `--resource-directory` args. The idea was to create two pexes: a requirements PEX and a sources PEX, then to merge the two via `PEX_PATH`. They would stay separate to increase the likelihood of cache hits. This solution failed, however, due to Pytest failing to discover any tests. See #8063 (comment) and the comment below it. #### Alternative attempted: only strip `PythonTarget`s The first idea was to only strip any subclass of `PythonTarget` and keep the full path for other target types like `files` (2b68ebd). This failed quickly, though, because the `VERSION` file is not able to correctly imported in this case. ### Result Two tests can be removed from the V2 blacklist without any changes to them required.
Eric-Arellano
force-pushed
the
v2-blacklist
branch
from
e92c438 to
e6db164
Compare
Eric-Arellano
force-pushed
the
v2-blacklist
branch
from
e6db164 to
e17b0ad
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Several of the tests work now without any changes, very likely thanks to #7866. These not only pass with V2, but also pass with remote execution.