Make notes for 1.19.0rc0, copy 1.19.0dev0 to the 1.19 notes file #8120
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
illicitonion
requested changes
Jul 29, 2019
There was a problem hiding this comment.
This is missing a bunch of the changes it needs, as per https://www.pantsbuild.org/release.html; specifically:
* Edit the version number in src/python/pants/VERSION
* Add the file to pants.ini in the branch_notes section.
* Add the new notes file to `src/docs/docsite.json`.
* Create a new page() in `src/python/pants/notes/BUILD` corresponding to the new notes.
| ====================== | ||
| This document describes releases leading up to the ``1.19.x`` ``stable`` series. | ||
|
|
||
| 1.19.0rc0 (29/07/2019) |
There was a problem hiding this comment.
I think this is missing like 10 commits?
There was a problem hiding this comment.
I'm not sure, because iirc the 1.18.rc0 notes only included the changes from 1.18.dev to the RC, and the range from the last dev release to this one is pretty narrow: https://pastebin.com/34YiZYEb
There was a problem hiding this comment.
I think your master may be a while out of date?
pants$ git log --oneline release_1.19.0.dev0..master
a5ddac3 Revert "use jdeps to run dep-usage task (#8093)"
d45af28 Fail for missing classpath entries with hermetic execution. (#8037)
adc9898 Properly manage the lifetime of Exiters in Daemon Runs (#7996)
96f6dd2 Deprecate ZincCompile task in favor of RscCompile (#8047)
23a8a2b Add support for scoverage (#8064)
536d216 Lower test timeouts in travis to get better debug output. (#8110)
a1b9eb9 Upgrade cloc to 1.80 and add error handling (#8111)
44c2741 Rewrite `test_git_hooks.py` to be hermetic (#8085)
b5d41da use jdeps to run dep-usage task (#8093)
0a45f40 Prepare 1.17.0rc2 and render 1.18.x. (#8114)
a996b57 Balance pytest test sharding (#8108)
1a1238e Record per-target compile workflow stats when using RscCompile (#8092)
89a6425 Parse zinc args and pass scalac options into scalafix (#8091)
5967b2f Loosen constraints on the jvm heap size for tests in extra_jvm_options (#8106)
4854194 Properly handle source roots and resources with V2 Pytest runner (#8063)
b76a9d2 add script to generate zinc native-images, with example usage (#8036)
81993f4 pants build committing publish data for push of org.pantsbuild#scoverage-report-generator_2.12;0.0.1 [ci skip]
b0877f8 Scoverage report generator (#8098)
e41ef3b [pantsd] Don't ignore the first watchman event for the daemon pid (#8096)
ec8e274 Add fs_util subcommand to list known directories (#8100)
0760fe8 [pantsd] Remove dead code around prefork graph warming (#8095)
570fab8 Report the stats version pants is using to the server. (#8086)
54d0d4e Use remote build execution to run several unit tests (#8051)
5fd255e Remove unused unit-test.sh script (#8083)
35be511 Update CONTRIBUTORS.md
74f280b Use direct import of version.py (#8078)
f9bb8d6 Refactor V2 PEX creation rules (#8080)
There was a problem hiding this comment.
OH shoot you're right, I need to rebase. Sorry :(
blorente
force-pushed
the
blorente/update-notes-1-19-rc0
branch
from
37dba99 to
7a6d050
Compare
stuhood
reviewed
Jul 29, 2019
| @@ -1 +1 @@ | |||
| 1.19.0.dev0 | |||
| 1.19.0.0rc0 | |||
There was a problem hiding this comment.
This has a spare 0. Will fix in #8123.
stuhood
pushed a commit
that referenced
this pull request
Jul 29, 2019
### Problem Merged #8120 without letting travis finish. That PR bumped the version, and that made two options deprecated. This means that almost all integration test shards fail in master. (e.g. https://travis-ci.org/pantsbuild/pants/jobs/565035360) ### Solution Remove both options, and their usages. ### Result Hopefully travis should be green. I tested the failing shards locally and they seem to work so far.
stuhood
reviewed
Jul 29, 2019
| @@ -73,6 +73,7 @@ | |||
| "notes-1.16.x": "dist/markdown/html/src/python/pants/notes/1.16.x.html", | |||
| "notes-1.17.x": "dist/markdown/html/src/python/pants/notes/1.17.x.html", | |||
| "notes-1.18.x": "dist/markdown/html/src/python/pants/notes/1.18.x.html", | |||
| "notes-1.19.x": "dist/markdown/html/src/python/pants/notes/1.19.x.html", | |||
There was a problem hiding this comment.
For future reference: in order for this page to be rendered on the left hand side of the site, it needs to be added to the Release notes section on line 201 in this file.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.