Add utility to extract macro classes from a classpath. #8201
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
olafurpg
commented
Aug 23, 2019
| import java.io.File | ||
|
|
||
| class FindMacrosSuite extends FunSuite with DiffAssertions { | ||
| test("expect") { |
There was a problem hiding this comment.
I think it might be worth using ignore for this test since it downloads quite a lot of jars from Maven Central and I estimate the FindMacros class won't change so frequently.
|
Sorry: looks like you were struck by #8127. |
stuhood
reviewed
Aug 25, 2019
|
Closing since #8145 got closed as well. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
To build a native image for the Scala compiler, we need to know the names of the classes on the compile classpath that define Scala macros.
Solution
This PR introduces a new
find-macroscommand-line tool that takes a classpath and prints out the names of the classes that define Scala macros. The tool finds class names by looking at the Scala signatures produced by the Scala compiler.