Make test discovery for test_testprojects.py IT more precise
#8395
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Eric-Arellano
changed the title
test_testprojects.py IT more precise
Eric-Arellano
force-pushed
the
precise-testprojects
branch
2 times, most recently
from
91af7a4 to
67c85ca
Compare
Eric-Arellano
force-pushed
the
precise-testprojects
branch
from
67c85ca to
f6231d3
Compare
stuhood
reviewed
Oct 5, 2019
| # `test` to trigger side effects via the goal graph, such as compiling JVM code or generating | ||
| # antlr code. Instead, we should run the specific command we are testing for that target type. | ||
| # For example, `python_antlr_library` would only need `./pants gen`. | ||
| for bfa in [ |
There was a problem hiding this comment.
Hm.
So, as discussed in Slack, I think that it would be better to do something like ./pants compile test lint here (or whichever other goals) and wait for #8368 to land.
There was a problem hiding this comment.
Hm okay. I redesigned this PR around this feedback. Abandonded the goal of mapping target types -> commands; instead, everything now uses ./pants compile lint test.
Also now blacklist certain target types, rather than this whitelist approach. IMO there is still value in skipping python_requirement_library and files() etc.
1) Blacklist certain target types, rather than whitelisting 2) Abandon idea of specific commands based on the target type. Everyone uses `./pants compile lint test` now
1) managed_jar_libraries is not recognized 2) target means that _everything_ will be skipped
|
Bump on this. I redesigned the approach and I think it's an improvement from before. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
Currently,
test_testproject.pyrunstestagainst everything intestprojects::andexamples::, including thefiles()targets we've been adding while porting to V2. We don't want those newfiles()targets to be run here.Solution
We blacklist certain target types that don't make sense to test.
We also now run
./pants compile lint teston every target. This does not make any difference now but prepares us for V2 where./pants testdoesn't trigger prerequisite goals as it does in V1.Result
We no longer test targets that don't make sense, like
files(). This prepares us for chrooting this test by allowing us to ignore targets we don't care about.