Revert "Revert dataclass engine params (#8540)" #8548
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cosmicexplorer
force-pushed
the
python-dataclasses
branch
from
081e1c0 to
59302a7
Compare
cosmicexplorer
force-pushed
the
python-dataclasses
branch
2 times, most recently
from
739bf3b to
6740a9d
Compare
cosmicexplorer
force-pushed
the
python-dataclasses
branch
3 times, most recently
from
526c647 to
45bd259
Compare
|
Great idea!! Will do!! |
This reverts commit 1aae1b5. review comments fix indentation [ci skip-rust-tests] # No Rust changes made. [ci skip-jvm-tests] # No JVM changes made. fix formatting [ci skip-rust-tests] # No Rust changes made. [ci skip-jvm-tests] # No JVM changes made. fix test failure [ci skip-jvm-tests] # No JVM changes made. [ci skip-rust-tests] # No Rust changes made. [ci skip-jvm-tests] # No JVM changes made.
# Delete this line to force CI to run the JVM tests. [ci skip-jvm-tests] # No JVM changes made.
cosmicexplorer
force-pushed
the
python-dataclasses
branch
from
45bd259 to
57fdbc6
Compare
|
Closing because we want this documentation to live in https://pants.readme.io/docs/plugins-overview. Once those docs are done, I think we'll want to delete this README. I'll incorporate your (very helpful!) changes in those docs, and I'd love any feedback on them once ready :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
This reverts commit 1aae1b5, with the intent to re-land #8181.
Solution
Rulesubclasses to provide better error messaging when engine Params are constructed that are unhashable. See update engine README for @dataclasses #9446 for more info.[ci skip-rust-tests] # No Rust changes made.
[ci skip-jvm-tests] # No JVM changes made.