Remove datatype() and TypedCollection
#8576
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Eric-Arellano
requested review from
stuhood,
jsirois,
benjyw,
illicitonion and
cosmicexplorer
cosmicexplorer
approved these changes
Nov 5, 2019
There was a problem hiding this comment.
I would change the text in the OP to say "resolves #7074" so it can be auto-closed.
jsirois
approved these changes
Nov 5, 2019
jsirois
approved these changes
Nov 5, 2019
jsirois
approved these changes
Nov 5, 2019
jsirois
approved these changes
Nov 5, 2019
jsirois
approved these changes
Nov 5, 2019
jsirois
approved these changes
Nov 5, 2019
|
Although I definitely approve, I'm not as excited as it may appear. There was / is an on-going Github web-hook delivery issue - sorry for the spam. |
benjyw
approved these changes
Nov 5, 2019
|
Thank you for the reviews and for the original datatype code (especially @cosmicexplorer)! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #7074. Now that we always use
@dataclassinstead ofdatatype, and replacedCollection.of(T)withCollection[T], it is safe to removedatatype().We also remove
TypedCollectionas it is no longer in use. Instead, we use explicit type hints likeTuple[str, ...]orCollection[T].We avoid a deprecation cycle because V2 engine code has always been experimental.
Keeps
util/objects.pyWe still keep
TypeConstraintError,Exactly,SuperclassesOf, andSubclassesOf. These are used widely in the codebase and have no standard library equivalent. They also do not seem to cause problems for MyPy.