Enable pantsd by default #9935
Merged
Enable pantsd by default #9935
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
# Delete this line to force CI to run Clippy and the Rust tests. [ci skip-rust-tests] # Delete this line to force CI to run the JVM tests. [ci skip-jvm-tests]
# Delete this line to force CI to run Clippy and the Rust tests. [ci skip-rust-tests] # Delete this line to force CI to run the JVM tests. [ci skip-jvm-tests]
# Delete this line to force CI to run Clippy and the Rust tests. [ci skip-rust-tests] # Delete this line to force CI to run the JVM tests. [ci skip-jvm-tests]
|
Commits are useful to review independently, but none of them is very large. |
stuhood
commented
Jun 1, 2020
| @@ -659,7 +636,7 @@ def register_bootstrap_options(cls, register): | |||
| type=bool, | |||
| advanced=True, | |||
| default=False, | |||
| removal_version="1.30.0.dev0", | |||
| removal_version="1.31.0.dev0", | |||
There was a problem hiding this comment.
I decided that it was better to be conservative here, and not delete this code until pantsd has been on by default for a version. Looking forward to removing it though, as it's about 1k lines and thirdparty dep!
jsirois
approved these changes
Jun 1, 2020
stuhood
force-pushed
the
stuhood/pantsd-by-default
branch
from
146783f to
ba60ba4
Compare
[ci skip-jvm-tests] [ci skip-rust-tests]
…ntil pantsd has been on by default for a little while. [ci skip-rust-tests] [ci skip-jvm-tests]
stuhood
force-pushed
the
stuhood/pantsd-by-default
branch
from
ba60ba4 to
716e91c
Compare
Eric-Arellano
approved these changes
Jun 1, 2020
There was a problem hiding this comment.
Great work, Stu!
Before 1.30 lands, it'd be good to do these two things:
- Fix
pants_ignore_warningsnot working with pantsd. (Lmk if it would help to create a ticket) - Add basic documentation to the new site about using pantsd from the perpsective of a user, e.g. debug tips.
Totally okay to do those in followups. This is a big accomplishment!
|
@Eric-Arellano : Filed #9938. |
|
This is amazing! Thank you so much for seeing this through, I've been following this from afar. Makes me so happy that it's finally great. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Enable pantsd by default, and remove related deprecated options.
Thank you to everyone who worked toward this end, particularly @kwlzn and @blorente!