Skip to content

Commit

Permalink
Check for .0a0 for new version creation, not .a0 (#163)
Browse files Browse the repository at this point in the history
Minor typo in the check for alpha versions meant it didn't trigger: it's
intending to search for `2.x.0a0`, i.e. first alpha version leading up
to the first stable release in `2.x` series... but missed the 0 between
the `.` and the `a`.

This explains
(#162 (comment)):
why we don't have a `versioned_docs/version-2.20` directory despite #153
landing.

This PR doesn't create that directory, just fixing the bug in the
automation. I've retriggered the sync from this PR's branch to do that:
#164
  • Loading branch information
huonw authored Feb 28, 2024
1 parent f277f26 commit c0c85d7
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion .github/workflows/sync_docs.yml
Original file line number Diff line number Diff line change
Expand Up @@ -75,7 +75,7 @@ jobs:
BASE_VERSION=$(echo "${{ inputs.version }}" | sed -E 's/^([0-9]+)\.([0-9]+)\.\w+.*/\1.\2/')
DESTINATION_DIR="versioned_docs/version-$BASE_VERSION"
if [ ! -d "$DESTINATION_DIR" ]; then
if [[ "${{ inputs.version }}" =~ .*\.a0$ ]]; then
if [[ "${{ inputs.version }}" =~ .*\.0a0$ ]]; then
# a0 => we've cut a new branch from `main`, so make a new version
npm run docusaurus docs:version $BASE_VERSION
else
Expand Down

0 comments on commit c0c85d7

Please sign in to comment.