Use papis add for import

[kiike]

As per discussion in papis/papis#765, this proposal imports papers from Zotero using the papis.command.add.run API instead of writing out yaml files. I took advantage to rename the arguments too and allow the use of the link argument.

[kiike]

So the tests fail on Windows due to the encoding error mentioned in the issues and PRs and that is blocked for an unreleased fix. Does this affect this PR? After merging perhaps an obvious step is marking the test as skippable on Windows.

[alexfikl]

Left two small questions, but overall this looks good to me! Thanks for working on it!

Have you tested it on your library too? Unfortunately the unittests are not particularly great here.. :(

[alexfikl]

So the tests fail on Windows due to the encoding error mentioned in the issues and PRs and that is blocked for an unreleased fix. Does this affect this PR? After merging perhaps an obvious step is marking the test as skippable on Windows.

Yeah, it would be great if you could add a little snippet at the top of the failing tests:

if sys.platform == "win32":
	pytest.xfail("Fails due to wrong enconding in papis<=0.13.")

We'll remove that when the new version is out.

[kiike]

Left two small questions, but overall this looks good to me! Thanks for working on it!

Have you tested it on your library too? Unfortunately the unittests are not particularly great here.. :(

Yes, I use it for my "production" library. I started working on this small patch since I didn't like how the default import left my library. I no longer had an easy way of navigating the documents except if i used the papis tui. Now, the file explorer lets me see which documents I have and also the citation for typst at the same time:

[alexfikl]

Yes, I use it for my "production" library. I started working on this small patch since I didn't like how the default import left my library. I no longer had an easy way of navigating the documents except if i used the papis tui. Now, the file explorer lets me see which documents I have and also the citation for typst at the same time:

That's awesome ❤️

[kiike]

The test is passing on my machine so I'll check what might be wrong here.

[kiike]

I just realised why the tests passed on my machine but not on CI. I had a modification in papis/commands/add so that folder_name was populated from args or from the config. This was needed as we are not using the CLI, to execute the papis.commands.add.run function.

Instead of modifying papis/commands/add, i am changing the function call here so we pass the folder_name as argument with the papis config.

[alexfikl]

Thanks for all the work! In it goes 🚀