Skip to content

Commit

Permalink
Add serde-bincode-compat for receipt (#14399)
Browse files Browse the repository at this point in the history
Co-authored-by: Matthias Seitz <[email protected]>
  • Loading branch information
programskillforverification and mattsse authored Feb 14, 2025
1 parent 16c3c5b commit 113a87b
Show file tree
Hide file tree
Showing 4 changed files with 21 additions and 2 deletions.
2 changes: 1 addition & 1 deletion crates/e2e-test-utils/Cargo.toml
Original file line number Diff line number Diff line change
Expand Up @@ -34,7 +34,7 @@ reth-engine-local.workspace = true
reth-tasks.workspace = true

# currently need to enable this for workspace level
reth-optimism-primitives = { workspace = true, features = ["arbitrary", "serde"] }
reth-optimism-primitives = { workspace = true, features = ["arbitrary", "serde", "serde-bincode-compat"] }

# rpc
jsonrpsee.workspace = true
Expand Down
9 changes: 9 additions & 0 deletions crates/ethereum/primitives/src/receipt.rs
Original file line number Diff line number Diff line change
Expand Up @@ -193,6 +193,15 @@ impl InMemorySize for Receipt {

impl reth_primitives_traits::Receipt for Receipt {}

#[cfg(feature = "serde-bincode-compat")]
impl reth_primitives_traits::serde_bincode_compat::SerdeBincodeCompat for Receipt {
type BincodeRepr<'a> = Self;

fn as_repr(&self) -> Self::BincodeRepr<'_> {
self.clone()
}
}

#[cfg(test)]
mod tests {
use super::*;
Expand Down
9 changes: 9 additions & 0 deletions crates/optimism/primitives/src/receipt.rs
Original file line number Diff line number Diff line change
Expand Up @@ -211,6 +211,15 @@ impl InMemorySize for OpReceipt {

impl reth_primitives_traits::Receipt for OpReceipt {}

#[cfg(feature = "serde-bincode-compat")]
impl reth_primitives_traits::serde_bincode_compat::SerdeBincodeCompat for OpReceipt {
type BincodeRepr<'a> = Self;

fn as_repr(&self) -> Self::BincodeRepr<'_> {
self.clone()
}
}

/// Trait for deposit receipt.
pub trait DepositReceipt: reth_primitives_traits::Receipt {
/// Returns deposit receipt if it is a deposit transaction.
Expand Down
3 changes: 2 additions & 1 deletion crates/primitives-traits/src/receipt.rs
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
//! Receipt abstraction
use crate::{InMemorySize, MaybeCompact, MaybeSerde};
use crate::{InMemorySize, MaybeCompact, MaybeSerde, MaybeSerdeBincodeCompat};
use alloc::vec::Vec;
use alloy_consensus::{
Eip2718EncodableReceipt, RlpDecodableReceipt, RlpEncodableReceipt, TxReceipt, Typed2718,
Expand All @@ -27,6 +27,7 @@ pub trait Receipt:
+ Typed2718
+ MaybeSerde
+ InMemorySize
+ MaybeSerdeBincodeCompat
{
}

Expand Down

0 comments on commit 113a87b

Please sign in to comment.