Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add rlp support for EthVersion #12195

Closed
mattsse opened this issue Oct 30, 2024 · 2 comments · Fixed by #12221
Closed

Add rlp support for EthVersion #12195

mattsse opened this issue Oct 30, 2024 · 2 comments · Fixed by #12221
Assignees
Labels
C-enhancement New feature or request D-good-first-issue Nice and easy! A great choice to get started

Comments

@mattsse
Copy link
Collaborator

mattsse commented Oct 30, 2024

Describe the feature

pub enum EthVersion {

ideally we want to replace

/// The current protocol version. For example, peers running `eth/66` would have a version of
/// 66.
pub version: u8,

with EthVersion entirely, so that we don't have to do:

version: EthVersion::Eth68 as u8,

Additional context

No response

@mattsse mattsse added C-enhancement New feature or request S-needs-triage This issue needs to be labelled labels Oct 30, 2024
@mattsse mattsse added D-good-first-issue Nice and easy! A great choice to get started and removed S-needs-triage This issue needs to be labelled labels Oct 30, 2024
@lean-apple
Copy link
Contributor

Hello, may I like to work on it ?

@mattsse
Copy link
Collaborator Author

mattsse commented Oct 30, 2024

assigned, ty

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
C-enhancement New feature or request D-good-first-issue Nice and easy! A great choice to get started
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

2 participants