Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add rlp support for EthVersion #12221

Merged
merged 4 commits into from
Oct 31, 2024

Conversation

lean-apple
Copy link
Contributor

Closes #12195.

Add rlp support for EthVersion, to be used as EthVersion::Eth68 for example and not as u8

@lean-apple lean-apple changed the title feat: add rlp support for eth version feat: add rlp support for EthVersion Oct 31, 2024
@lean-apple lean-apple marked this pull request as ready for review October 31, 2024 01:42
Copy link
Collaborator

@mattsse mattsse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

cool, this is a lot cleaner, ty!

@mattsse mattsse added C-debt Refactor of code section that is hard to understand or maintain A-networking Related to networking in general labels Oct 31, 2024
@mattsse mattsse added this pull request to the merge queue Oct 31, 2024
Merged via the queue into paradigmxyz:main with commit c19af29 Oct 31, 2024
40 checks passed
@lean-apple lean-apple deleted the eth-version-rlp-support branch October 31, 2024 08:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-networking Related to networking in general C-debt Refactor of code section that is hard to understand or maintain
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add rlp support for EthVersion
2 participants