Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add benchmarks for MerkleStage #1234

Closed
MegaRedHand opened this issue Feb 8, 2023 · 2 comments
Closed

Add benchmarks for MerkleStage #1234

MegaRedHand opened this issue Feb 8, 2023 · 2 comments
Assignees
@MegaRedHand
Labels
C-benchmark A change that impacts how or what we benchmark C-enhancement New feature or request

Comments

@MegaRedHand
Copy link
Contributor

Describe the feature

The stage was introduced in #994, and is a good target for optimization, but first we need benchmarks.

Additional context

No response
@MegaRedHand MegaRedHand added C-enhancement New feature or request S-needs-triage This issue needs to be labelled labels Feb 8, 2023
@gakonst
Copy link
Member

gakonst commented Feb 11, 2023

See how these synthetic data benchmarks work: https://github.com/paradigmxyz/reth/blob/main/crates/stages/benches/criterion.rs

@MegaRedHand MegaRedHand mentioned this issue Feb 13, 2023
Closed
@onbjerg onbjerg added C-benchmark A change that impacts how or what we benchmark and removed S-needs-triage This issue needs to be labelled labels Feb 14, 2023
@onbjerg onbjerg moved this from Todo to In Progress in Reth Tracker Feb 14, 2023
@MegaRedHand
Copy link
Contributor Author

Continued in #1497

@github-project-automation github-project-automation bot moved this from In Progress to Done in Reth Tracker Mar 1, 2023
johntaiko added a commit to taikoxyz/taiko-reth that referenced this issue Sep 12, 2024
@johntaiko
refactor: Enable anchor and skip options in BlockExecutionInput
7f6ff7b 
This commit refactors the `BlockExecutionInput` struct in the `execute.rs` file of the `evm` crate. It replaces the `disable_anchor` field with an `enable_anchor` field and adds an `enable_skip` field. These options allow for enabling or disabling the anchor transaction and skipping invalid transactions during block execution.

Ref: paradigmxyz#1234
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@MegaRedHand MegaRedHand

Labels
C-benchmark A change that impacts how or what we benchmark C-enhancement New feature or request
Projects
Reth Tracker
Archived in project
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

bench: merkle stage lambdaclass/reth
3 participants
@onbjerg @gakonst @MegaRedHand