Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

eth_getBlockByNumber header num has leading zeros #1486

Closed
1 task done
Rjected opened this issue Feb 21, 2023 · 4 comments
Closed
1 task done

eth_getBlockByNumber header num has leading zeros #1486

Rjected opened this issue Feb 21, 2023 · 4 comments
Assignees
Labels
A-rpc Related to the RPC implementation C-bug An unexpected or incorrect behavior

Comments

@Rjected
Copy link
Member

Rjected commented Feb 21, 2023

Describe the bug

The ethereum/sync test fails because our rpc output is not able to be parsed:

can't query chain head: json: cannot unmarshal hex number with leading zero digits into Go struct field Header.number of type *hexutil.Big

Steps to reproduce

Run the ethereum/sync hive tests on latest main, see the hive workflow: https://github.com/paradigmxyz/reth/actions/runs/4234007156/jobs/7356032570#step:7:8

Node logs

No response

Platform(s)

No response

What version/commit are you on?

No response

Code of Conduct

  • I agree to follow the Code of Conduct
@Rjected Rjected added C-bug An unexpected or incorrect behavior A-rpc Related to the RPC implementation labels Feb 21, 2023
@Rjected
Copy link
Member Author

Rjected commented Feb 21, 2023

This is caused by:
recmo/uint#224
and tracked in reth with:
#1465

@gakonst
Copy link
Member

gakonst commented Feb 22, 2023

Remco is away on parental leave for another month I think, so would recommend using a custom deserializer. @Rjected assigning to you, should be smol

@mattsse
Copy link
Collaborator

mattsse commented Feb 22, 2023

we'd need to use different types everywhere which would be a pain
perhaps we can patch with this fix instead recmo/uint#225?

@gakonst
Copy link
Member

gakonst commented Feb 22, 2023

I'm down to just cargo.patch the ruint dep until then yeah.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-rpc Related to the RPC implementation C-bug An unexpected or incorrect behavior
Projects
Archived in project
Development

No branches or pull requests

3 participants