Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: patch ruint with quantity fix #1518

Merged
merged 2 commits into from
Feb 22, 2023
Merged

fix: patch ruint with quantity fix #1518

merged 2 commits into from
Feb 22, 2023

Conversation

mattsse
Copy link
Collaborator

@mattsse mattsse commented Feb 22, 2023

Closes #1465 #1486 by patching ruint with recmo/uint#225

can be removed once merged into ruint or a decision is made that default serialize impl should include leading zeros in which case we need to replace U256 with a wrapper type..

 cast block-number
0
TRACE connection{remote_addr=127.0.0.1:51676 conn_id=0}:method_call{method="eth_blockNumber"}: send="{\"jsonrpc\":\"2.0\",\"result\":\"0x0\",\"id\":1}"

@mattsse mattsse requested a review from gakonst as a code owner February 22, 2023 21:45
@mattsse mattsse added A-rpc Related to the RPC implementation A-dependencies Pull requests or issues that are about dependencies labels Feb 22, 2023
@codecov-commenter
Copy link

codecov-commenter commented Feb 22, 2023

Codecov Report

Merging #1518 (2efc6b9) into main (8094ab1) will decrease coverage by 0.02%.
The diff coverage is 100.00%.

📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more

@@            Coverage Diff             @@
##             main    #1518      +/-   ##
==========================================
- Coverage   76.07%   76.05%   -0.02%     
==========================================
  Files         358      358              
  Lines       42759    42761       +2     
==========================================
- Hits        32528    32521       -7     
- Misses      10231    10240       +9     
Flag Coverage Δ
integration-tests 21.85% <0.00%> (+0.03%) ⬆️
unit-tests 70.51% <100.00%> (-0.03%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
crates/primitives/src/jsonu256.rs 93.42% <100.00%> (-0.25%) ⬇️
crates/net/discv4/src/proto.rs 89.66% <0.00%> (-3.13%) ⬇️
crates/stages/src/stages/sender_recovery.rs 90.95% <0.00%> (-0.54%) ⬇️
crates/stages/src/stages/hashing_storage.rs 95.65% <0.00%> (-0.28%) ⬇️
crates/net/discv4/src/lib.rs 66.23% <0.00%> (+0.07%) ⬆️
crates/net/network/src/manager.rs 52.49% <0.00%> (+0.18%) ⬆️
crates/transaction-pool/src/pool/mod.rs 45.33% <0.00%> (+0.46%) ⬆️
crates/transaction-pool/src/validate.rs 52.23% <0.00%> (+0.72%) ⬆️
crates/net/eth-wire/src/capability.rs 75.00% <0.00%> (+0.73%) ⬆️
crates/transaction-pool/src/test_utils/mock.rs 68.15% <0.00%> (+1.25%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@gakonst gakonst merged commit 0cf27ce into main Feb 22, 2023
@gakonst gakonst deleted the matt/patch-ruint branch February 22, 2023 22:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-dependencies Pull requests or issues that are about dependencies A-rpc Related to the RPC implementation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

U256 RPC are not quantity
3 participants