Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add impl From BlockExecutionOutput for ExecutionOutcome #10507

Merged
merged 2 commits into from
Aug 25, 2024
Merged

feat: add impl From BlockExecutionOutput for ExecutionOutcome #10507

merged 2 commits into from
Aug 25, 2024

Conversation

nkysg
Copy link
Contributor

@nkysg nkysg commented Aug 25, 2024 •
edited
Loading

add impl From BlockExecutionOutput for ExecutionOutcome

@nkysg nkysg changed the title impl From<(BlockExecutionOutput<Receipt>, BlockNumber)> for ExecutionOutcome impl From for ExecutionOutcome Aug 25, 2024
@nkysg nkysg changed the title impl From for ExecutionOutcome feat: impl From BlockExecutionOutput for ExecutionOutcome Aug 25, 2024
@nkysg nkysg changed the title feat: impl From BlockExecutionOutput for ExecutionOutcome feat: add impl From BlockExecutionOutput for ExecutionOutcome Aug 25, 2024
emhane
emhane approved these changes Aug 25, 2024
View reviewed changes
Copy link
Member

@emhane emhane left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

was this linked to any issue?

@emhane emhane added this pull request to the merge queue Aug 25, 2024
Merged via the queue into paradigmxyz:main with commit 5254f16 Aug 25, 2024
34 checks passed
@nkysg nkysg deleted the execution_outcome_from branch August 25, 2024 21:05
emnul
emnul approved these changes Aug 25, 2024
View reviewed changes
Copy link
Contributor

@emnul emnul left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The code is a lot cleaner now. Great job!

@nkysg
Copy link
Contributor Author

nkysg commented Aug 25, 2024

was this linked to any issue?

will add some issue next time.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@emhane emhane emhane approved these changes

@emnul emnul emnul approved these changes

@rakita rakita Awaiting requested review from rakita rakita is a code owner

@mattsse mattsse Awaiting requested review from mattsse mattsse is a code owner

@Rjected Rjected Awaiting requested review from Rjected Rjected is a code owner

@rkrasiuk rkrasiuk Awaiting requested review from rkrasiuk rkrasiuk is a code owner

@fgimenez fgimenez Awaiting requested review from fgimenez fgimenez is a code owner

@onbjerg onbjerg Awaiting requested review from onbjerg onbjerg is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@nkysg @emnul @emhane