dev: add send_and_resolve #10847
Merged
dev: add send_and_resolve #10847
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mattsse
requested changes
Sep 12, 2024
Comment on lines
31
to
32
| type MaybePayloadFuture<P> = | ||
| Pin<Box<dyn Future<Output = Option<Result<P, PayloadBuilderError>>> + Send + Sync>>; |
There was a problem hiding this comment.
I don't think we need this
| @@ -127,6 +129,31 @@ where | |||
| } | |||
| } | |||
|
|
|||
| /// Sends a message to the service to start building a new payload for the given payload | |||
| /// attributes and returns a future that resolves to the payload. | |||
| pub fn send_and_resolve_payload( | |||
There was a problem hiding this comment.
this can just be an async function
Comment on lines
142
to
153
| let id = match rx.await { | ||
| Err(e) => return Some(Err(e.into())), | ||
| Ok(Err(e)) => return Some(Err(e)), | ||
| Ok(Ok(id)) => id, | ||
| }; | ||
|
|
||
| let (tx, rx) = oneshot::channel(); | ||
| to_service.send(PayloadServiceCommand::Resolve(id, tx)).ok()?; | ||
| match rx.await.transpose()? { | ||
| Ok(fut) => Some(fut.await), | ||
| Err(e) => Some(Err(e.into())), | ||
| } |
There was a problem hiding this comment.
then you can do all of this without the Box::pin
There was a problem hiding this comment.
Ah ok I thought you wanted to return a future, will update
There was a problem hiding this comment.
yeah but you can return Option<PayloadFuture>
or result PayloadFuture, PayloadNotfound
greged93
force-pushed
the
dev/payload-handle
branch
from
e6f3e1d to
15eb510
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds a send and resolve helper on the
PayloadBuilderHandle. This helper allows to request for a payload to be build based on the provided payload builder attribute and returns a future that resolves to the payload.Resolves #10845