Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(lint): lint warnings for db benchmark tools #11011

Merged
merged 2 commits into from
Sep 19, 2024
Merged

fix(lint): lint warnings for db benchmark tools #11011

merged 2 commits into from
Sep 19, 2024

Conversation

emhane
Copy link
Member

@emhane emhane commented Sep 19, 2024

Fixes lint warnings for db benchmark tools

@emhane emhane added C-bug An unexpected or incorrect behavior C-docs An addition or correction to our documentation A-utils Related to commonly used utilities labels Sep 19, 2024
@emhane emhane requested review from onbjerg and DaniPopes and removed request for rakita and joshieDo September 19, 2024 00:28
@emhane emhane added C-benchmark A change that impacts how or what we benchmark and removed A-utils Related to commonly used utilities labels Sep 19, 2024
@DaniPopes
Copy link
Member

What commands are you running to get these lints?

mattsse
mattsse approved these changes Sep 19, 2024
View reviewed changes
Copy link
Collaborator

@mattsse mattsse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

these are new nightly clippy lints

see #10905

@mattsse mattsse added this pull request to the merge queue Sep 19, 2024
Merged via the queue into main with commit 5f022e1 Sep 19, 2024
36 checks passed
@mattsse mattsse deleted the emhane/lint-bench branch September 19, 2024 12:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mattsse mattsse mattsse approved these changes

@onbjerg onbjerg Awaiting requested review from onbjerg

@DaniPopes DaniPopes Awaiting requested review from DaniPopes

Assignees
No one assigned
Labels
C-benchmark A change that impacts how or what we benchmark C-bug An unexpected or incorrect behavior C-docs An addition or correction to our documentation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@emhane @DaniPopes @mattsse