fix: reset pruned sender numbers on stage drop #11150
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We may get over 100% stage progress if we do:
This is because we count pruned transactions towards progress:
reth/crates/stages/stages/src/stages/sender_recovery.rs
Lines 291 to 303 in f9b8dc4
This naive fix resets the pruned numbers when we drop the sender recovery stage. Hope it doesn't break something else 😅.