Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(exex): write notification files atomically #11264

Merged
merged 8 commits into from
Sep 26, 2024
Merged

feat(exex): write notification files atomically #11264

merged 8 commits into from
Sep 26, 2024

Conversation

joshieDo
Copy link
Collaborator

@joshieDo joshieDo commented Sep 26, 2024 •
edited
Loading

closes #11257

  • add fn atomic_write_file(path, write_fn) to reth_fs_utils
  • nippy-jar now uses atomic_write_file
  • wal uses atomic_write_file for notifications

@joshieDo joshieDo added C-enhancement New feature or request A-exex Execution Extensions labels Sep 26, 2024
@joshieDo joshieDo changed the title feat: write notification files atomically feat(exex): write notification files atomically Sep 26, 2024
shekhirin
shekhirin reviewed Sep 26, 2024
View reviewed changes
crates/exex/exex/src/wal/storage.rs Outdated Show resolved Hide resolved
crates/fs-util/src/lib.rs Outdated Show resolved Hide resolved
crates/fs-util/src/lib.rs Show resolved Hide resolved
crates/fs-util/src/lib.rs Outdated Show resolved Hide resolved
crates/storage/nippy-jar/src/lib.rs Outdated Show resolved Hide resolved
shekhirin
shekhirin approved these changes Sep 26, 2024
View reviewed changes
Copy link
Collaborator

@shekhirin shekhirin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, one nit on removed TODO

crates/exex/exex/src/wal/storage.rs Show resolved Hide resolved
@joshieDo joshieDo enabled auto-merge September 26, 2024 21:11
@joshieDo joshieDo added this pull request to the merge queue Sep 26, 2024
Merged via the queue into main with commit da6b1e7 Sep 26, 2024
35 checks passed
@joshieDo joshieDo deleted the joshie/atomic-write branch September 26, 2024 21:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shekhirin shekhirin shekhirin approved these changes

@onbjerg onbjerg Awaiting requested review from onbjerg onbjerg is a code owner

@emhane emhane Awaiting requested review from emhane

Assignees
No one assigned
Labels
A-exex Execution Extensions C-enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

ExEx WAL should write notifications to files atomically
2 participants
@joshieDo @shekhirin