use core::error::Error
#11317
Merged
use core::error::Error
#11317
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
onbjerg
approved these changes
Sep 29, 2024
onbjerg
reviewed
Sep 29, 2024
| #[cfg(feature = "std")] | ||
| impl std::error::Error for ProviderError { | ||
| fn source(&self) -> Option<&(dyn std::error::Error + 'static)> { | ||
| impl core::error::Error for ProviderError { |
There was a problem hiding this comment.
is the std feature here (and in the other changed files) used for anything in their respective crates anymore?
There was a problem hiding this comment.
Yes normally I checked and I see in the two or three crates concerned another use either for display, std::path::PathBuf or another use
onbjerg
added
the
C-debt
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Should close #11312