Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: always handle payload building for opstack #11629

Merged
merged 3 commits into from
Oct 10, 2024

Conversation

mattsse
Copy link
Collaborator

@mattsse mattsse commented Oct 10, 2024

this ports missing check for opstack because there we always need to trigger a new payload job if this happens

// On Optimism, the proposers are allowed to reorg their own chain at will.
#[cfg(feature = "optimism")]
if reth_chainspec::EthChainSpec::chain(self.blockchain.chain_spec().as_ref()).is_optimism()
{
debug!(
target: "consensus::engine",
fcu_head_num=?header.number,
current_head_num=?head.number,
"[Optimism] Allowing beacon reorg to old head"
);
return true
}

This adds is_optimism to ethchainspec trait for simplicity, which isn't great but also not horrible

@mattsse mattsse added the A-op-reth Related to Optimism and op-reth label Oct 10, 2024
@mattsse mattsse enabled auto-merge October 10, 2024 09:35
@mattsse mattsse added this pull request to the merge queue Oct 10, 2024
Merged via the queue into main with commit eb9565d Oct 10, 2024
37 checks passed
@mattsse mattsse deleted the matt/build-payload-for-opstack branch October 10, 2024 09:56
vandenbogart pushed a commit to testmachine-ai/reth that referenced this pull request Oct 14, 2024
reymom pushed a commit to reymom/reth that referenced this pull request Oct 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-op-reth Related to Optimism and op-reth
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants