Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Introduce trait for OpTransaction #11745

Merged
merged 18 commits into from
Oct 29, 2024
Merged

feat: Introduce trait for OpTransaction #11745

merged 18 commits into from
Oct 29, 2024

Conversation

hoank101
Copy link
Contributor

Closed #11736

mattsse
mattsse requested changes Oct 15, 2024
View reviewed changes
crates/primitives/src/transaction/mod.rs Show resolved Hide resolved
crates/optimism/evm/src/execute.rs Outdated Show resolved Hide resolved
Cargo.toml Outdated Show resolved Hide resolved
@hoank101 hoank101 requested a review from mattsse October 15, 2024 14:44
@hoank101 hoank101 marked this pull request as ready for review October 15, 2024 15:13
@mattsse mattsse added the S-blocked This cannot more forward until something else changes label Oct 15, 2024
@hoank101
Copy link
Contributor Author

hi @mattsse can you help me review, now not blocked

mattsse
mattsse approved these changes Oct 29, 2024
View reviewed changes
Copy link
Collaborator

@mattsse mattsse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@mattsse mattsse enabled auto-merge October 29, 2024 14:14
@mattsse mattsse added this pull request to the merge queue Oct 29, 2024
Merged via the queue into paradigmxyz:main with commit e92ecfb Oct 29, 2024
41 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mattsse mattsse mattsse approved these changes

@Rjected Rjected Awaiting requested review from Rjected Rjected is a code owner

@fgimenez fgimenez Awaiting requested review from fgimenez fgimenez is a code owner

@emhane emhane Awaiting requested review from emhane

@gakonst gakonst Awaiting requested review from gakonst gakonst is a code owner

Assignees
No one assigned
Labels
S-blocked This cannot more forward until something else changes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Introduce trait for OpTransaction
2 participants
@hoank101 @mattsse