New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor(tx-pool): move `is_underpriced` to `ValidPoolTransaction` impl #11938

Merged

mattsse merged 2 commits into paradigmxyz:main from tcoratger:is_underpriced

Oct 23, 2024

Contributor

tcoratger commented Oct 21, 2024

As is_underpriced contains two ValidPoolTransaction as arguments, it seems more logical to move the function inside ValidPoolTransaction implementation.
The documentation is a little bit improved to explain steps because there are a lot of calculations there.
unwrap_or(0) is replaced by default usage
In if conditions, simplest assertions to check are moved first for the function to output fast is this necessary condition is not met.


          refactor(tx-pool): move is_underpriced to ValidPoolTransaction impl

eab7f00

tcoratger requested a review from mattsse as a code owner

October 21, 2024 17:06


          clippy

1ff9495

mattsse approved these changes

View reviewed changes

mattsse added this pull request to the merge queue

mattsse added the A-tx-pool label

github-merge-queue bot removed this pull request from the merge queue due to failed status checks

mattsse merged commit ee1260a into paradigmxyz:main

38 checks passed

This was referenced Oct 24, 2024

Merge upstream HashFramework/reth#3

Closed

Merge upstream HashFramework/reth#4

Closed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels