Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: ExExContext's dynamic config #11983

Merged
merged 11 commits into from
Oct 24, 2024
Merged

feat: ExExContext's dynamic config #11983

merged 11 commits into from
Oct 24, 2024

Conversation

0xurb
Copy link
Contributor

@0xurb 0xurb commented Oct 22, 2024

By

  • making EthChainSpec object-safe
  • making conversion between NodeConfig<T> -> NodeConfig<Box<dyn EthChainSpec + 'static>>

@0xurb 0xurb mentioned this pull request Oct 22, 2024
Closed
shekhirin
shekhirin requested changes Oct 23, 2024
View reviewed changes
crates/chainspec/src/api.rs Outdated Show resolved Hide resolved
crates/node/core/src/node_config.rs Outdated Show resolved Hide resolved
crates/node/types/src/lib.rs Outdated Show resolved Hide resolved
mattsse
mattsse requested changes Oct 23, 2024
View reviewed changes
crates/chainspec/src/api.rs Show resolved Hide resolved
crates/chainspec/src/api.rs Show resolved Hide resolved
crates/exex/exex/src/dyn_context.rs Show resolved Hide resolved
crates/exex/exex/src/dyn_context.rs Outdated Show resolved Hide resolved
crates/exex/exex/src/dyn_context.rs Outdated Show resolved Hide resolved
@0xurb 0xurb marked this pull request as ready for review October 24, 2024 11:54
shekhirin
shekhirin approved these changes Oct 24, 2024
View reviewed changes
Copy link
Collaborator

@shekhirin shekhirin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is good enough for now and we have a couple TODOs in issues for improving this, LGTM. @mattsse can you please take a look?

@mattsse mattsse enabled auto-merge October 24, 2024 13:27
@mattsse mattsse added this pull request to the merge queue Oct 24, 2024
Merged via the queue into paradigmxyz:main with commit 2fba3c0 Oct 24, 2024
38 checks passed
@mattsse mattsse mentioned this pull request Oct 24, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shekhirin shekhirin shekhirin approved these changes

@mattsse mattsse mattsse approved these changes

@Rjected Rjected Awaiting requested review from Rjected Rjected is a code owner

@fgimenez fgimenez Awaiting requested review from fgimenez fgimenez is a code owner

@emhane emhane Awaiting requested review from emhane

@onbjerg onbjerg Awaiting requested review from onbjerg onbjerg is a code owner

@joshieDo joshieDo Awaiting requested review from joshieDo joshieDo is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@0xurb @shekhirin @mattsse