feat(rpc): Start to implement flashbots_validateBuilderSubmissionV3 #12061
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Currently just parses params and accepts all inputs. * Mainly so we can unblock kurtosis testing for pectra
mattsse
reviewed
Oct 25, 2024
ryanschneider
requested review from
Rjected,
emhane and
gakonst
as code owners
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This first incremental version just accepts all inputs it can deserialize for
flashbots_validateBuilderSubmissionV3. To make it clear this is the case, it logs each request at warning level.The older V1 and V2 RPCs are left unimplemented, they were used for older forks so I can't see a good reason to implement them, but they are needed to complete the
BlockSubmissionValidationApiServertrait.Next steps are:
But just having this stub available allows us to make progress on switching https://github.com/ethpandaops/ethereum-package/tree/bbusa/rbuilder over to using
rbuilderandrethfor block building in kurtosis.