Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: change PayloadConfig to use parent header instead of parent block #12159

Merged
merged 3 commits into from
Oct 29, 2024
Merged

refactor: change PayloadConfig to use parent header instead of parent block #12159

merged 3 commits into from
Oct 29, 2024

Conversation

lean-apple
Copy link
Contributor

Closes #12103.

Optimizes PayloadConfig by using parent header instead of the full parent block.

@lean-apple lean-apple marked this pull request as draft October 29, 2024 06:46
@joshieDo joshieDo added A-block-building Related to block building C-debt Refactor of code section that is hard to understand or maintain labels Oct 29, 2024
@lean-apple lean-apple marked this pull request as ready for review October 29, 2024 07:24
mattsse
mattsse approved these changes Oct 29, 2024
View reviewed changes
Copy link
Collaborator

@mattsse mattsse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@mattsse mattsse added this pull request to the merge queue Oct 29, 2024
Merged via the queue into paradigmxyz:main with commit 7880d4d Oct 29, 2024
40 checks passed
@hai-rise hai-rise mentioned this pull request Oct 29, 2024
Closed
@lean-apple lean-apple deleted the payload-config-parent-header branch October 31, 2024 08:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@joshieDo joshieDo joshieDo approved these changes

@mattsse mattsse mattsse approved these changes

@Rjected Rjected Awaiting requested review from Rjected Rjected is a code owner

@fgimenez fgimenez Awaiting requested review from fgimenez fgimenez is a code owner

@emhane emhane Awaiting requested review from emhane

@onbjerg onbjerg Awaiting requested review from onbjerg onbjerg is a code owner

@gakonst gakonst Awaiting requested review from gakonst gakonst is a code owner

Assignees
No one assigned
Labels
A-block-building Related to block building C-debt Refactor of code section that is hard to understand or maintain
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

PayloadConfig: Downsize parent_block to parent_header
3 participants
@lean-apple @mattsse @joshieDo