feat: flashbots_validateBuilderSubmissionV3
#12168
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
A-rpc
| /// <https://github.com/flashbots/builder/blob/7577ac81da21e760ec6693637ce2a81fe58ac9f8/eth/block-validation/api.go#L198-L202> | ||
| #[serde_as] | ||
| #[derive(Clone, Debug, PartialEq, Eq, Serialize, Deserialize)] | ||
| pub struct BuilderBlockValidationRequestV3 { |
There was a problem hiding this comment.
Why not use the one from alloy? https://github.com/alloy-rs/alloy/blob/c4f3543361db76f960bdf65cff86d5c4088fa908/crates/rpc-types-beacon/src/relay.rs#L216
There was a problem hiding this comment.
that's temporary until we have a release with alloy-rs/alloy#1577 included
|
@ryanschneider this should be complete, still blocked on alloy release though |
klkvr
requested review from
mattsse,
Rjected,
emhane,
onbjerg and
gakonst
as code owners
klkvr
changed the title
flashbots_validateBuilderSubmissionV3flashbots_validateBuilderSubmissionV3
mattsse
approved these changes
Oct 31, 2024
mattsse
requested changes
Oct 31, 2024
mattsse
approved these changes
Oct 31, 2024
|
Looks great @klkvr! Thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #12132
Core logic is already ported, blacklisted addresses checks and configuration are missing for now. Also need to expose exiting configuration options to CLI.
I've added
Consensusgeneric to rpc-builder types so that we can use it onValidationApito validate blocks/headers