chore: only fetch deposit info for deposit tx #12474
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yeah, this would have to be a separate field with another serde hack. would we just fetch the nonce from historical state to account for that? |
klkvr
approved these changes
Nov 12, 2024
|
for rpc the nonce is fetched from the receipt... just like the deposit_version |
|
ah right there's deposit_nonce in there too |
3 tasks
github-merge-queue bot
pushed a commit
to alloy-rs/op-alloy
that referenced
this pull request
Nov 12, 2024
<!-- Thank you for your Pull Request. Please provide a description above and review the requirements below. Bug fixes and new features should include tests. Contributors guide: https://github.com/alloy-rs/core/blob/main/CONTRIBUTING.md The contributors guide includes instructions for running rustfmt and building the documentation. --> <!-- ** Please select "Allow edits from maintainers" in the PR Options ** --> ## Motivation ref paradigmxyz/reth#12474 We need a separate `deposit_nonce` to account for deposit transaction responses which have it while it's not present in inner envelope. ## Solution Adds `nonce` field to `OptionalFields` helper. It would get deserialized only if envelope did not consume it and serialized only if present and inner envelope is a deposit ## PR Checklist - [ ] Added Tests - [ ] Added Documentation - [ ] Breaking changes
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
we only have to fetch this for deposit tx
there is one more issue for #11708 because currently we can't easily set the nonce field for deposit txs
should we introduce this as additional field on op-alloy's tx type @klkvr ?