chore(sdk): add NetworkPrimitives for NetworkManager #12530
Conversation
lakshya-sky
requested review from
emhane,
mattsse and
Rjected
as code owners
|
you should also add generic to its implementations, eg here: reth/crates/net/network/src/manager.rs Line 119 in 68a6ada this would highlight some more places where generic is required |
Rjected
changed the title
|
@klkvr could you help me a bit here? I've updated all the places but it seems I can't keep up with the chain of all generics. |
examples/bsc-p2p/Cargo.toml
Outdated
| @@ -15,6 +15,7 @@ reth-network-api.workspace = true | |||
| reth-network-peers.workspace = true | |||
| reth-primitives.workspace = true | |||
| reth-tracing.workspace = true | |||
| reth-eth-wire-types.workspace = true | |||
There was a problem hiding this comment.
we should avoid this additional import and instead re-export EthNetworkPrimitives from the network crate
crates/net/network-api/src/events.rs
Outdated
There was a problem hiding this comment.
this I'd like to change separately
|
@lakshya-sky the issue is that here stream expects a stream of I think for now it should be OK to remove NetworkPrimitives generic from NodeEvent and instead just convert or as Matt mentioned we can just avoid touching events for now |
Co-authored-by: dkathiriya <[email protected]>
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
closes #12517