-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: refactoring reth_methods() to return multiple Methods #1284
Conversation
Codecov Report
📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more @@ Coverage Diff @@
## main #1284 +/- ##
==========================================
- Coverage 76.39% 76.18% -0.21%
==========================================
Files 343 347 +4
Lines 38426 38487 +61
==========================================
- Hits 29354 29323 -31
- Misses 9072 9164 +92
Flags with carried forward coverage won't be shown. Click here to find out more.
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
&mut self, | ||
namespaces: impl Iterator<Item = RethRpcModule>, | ||
) -> Vec<Methods> { | ||
let eth_api = self.eth_api(); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this will always create an EthApi
instance even though it might not be used.
It will not register it, if not required.
This is fine and perhaps even comes in handy when we need to returns the EthAPI somehow
Closes #1268