feat: bump alloy #12930
Merged
feat: bump alloy #12930
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
klkvr
force-pushed
the
klkvr/bump-alloy
branch
from
4eeaccd to
ed43e2c
Compare
Closed
mattsse
requested changes
Nov 28, 2024
Comment on lines
+289
to
+290
| // TODO: add as an argument and handle in `try_into_block` | ||
| target_blobs_per_block: 0, |
There was a problem hiding this comment.
let's track these separately
1 task
mattsse
approved these changes
Nov 30, 2024
mattsse
added
A-dependencies
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR mostly includes devnet-5 changes:
EIP-7742 feat: EIP-7742 alloy-rs/alloy#1600extracted to feat: EIP-7742 #12957EIP-7742 is pretty invasive as it affects calculation of excess blob gas and blob fee and thus needs changes in evm, consensus, payload builder, etc.
I've added a helper fn to
reth-consensus-commonwhich calculates next block's excess blob fee based on the chain spec, timestamp and parent header. This fn is used in all components which need to compute the excess blob feeThis still does not cover all cases, e.g
fill_block_envstill delegates basefee computation to revm which does not account for EIP-7742 (cc @rakita)reth/crates/evm/src/lib.rs
Lines 175 to 177 in d780bee
This is also breaking for Odyssey as it now requires any post-prague to include
target_blob_count